Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psrp - use native copy mechanism #71409

Merged
merged 3 commits into from Aug 25, 2020
Merged

psrp - use native copy mechanism #71409

merged 3 commits into from Aug 25, 2020

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Aug 22, 2020 •
edited

SUMMARY

Instead of creating a custom WinRS shell to provide the copy mechanisms this PR changes the process to the PSRP runspace itself. This is slightly slower than before due to the data being serialized in a PSRP fragment but it keeps the connection plugin purely PSRP.

Fixes: #59795

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

psrp

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Aug 22, 2020
@ansibot
Copy link
Contributor

ansibot commented Aug 22, 2020

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/connection/psrp.py:461:12: ansible-deprecated-no-collection-name: No collection name found in call to Display.deprecated or AnsibleModule.deprecate

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 22, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 22, 2020
@jborean93 jborean93 mentioned this pull request Aug 24, 2020
Closed
@egmar
Copy link
Contributor

egmar commented Aug 24, 2020 •
edited

Works fine in my test. Any chance this will be back-ported to 2.9.x/2.10?

@jborean93
Copy link
Contributor Author

Thanks for testing @egmar. I can try and backport the bits without the deprecation warning but it will be up to the release manager as to whether they would accept it for previous releases.

@jborean93 jborean93 merged commit 985ba18 into ansible:devel Aug 25, 2020
@jborean93 jborean93 deleted the psrp-copy branch August 25, 2020 02:24
jborean93 added a commit to jborean93/ansible that referenced this pull request Aug 25, 2020
@jborean93
psrp - use native copy mechanism (ansible#71409)
8edf95d 
* psrp - use native copy mechanism

* Fix sanity issues

* Split the bugfix and deprecation into separate changelog fragments

(cherry picked from commit 985ba18)
jborean93 added a commit to jborean93/ansible that referenced this pull request Aug 25, 2020
@jborean93
psrp - use native copy mechanism (ansible#71409)
144c6f4 
* psrp - use native copy mechanism

* Fix sanity issues

* Split the bugfix and deprecation into separate changelog fragments

(cherry picked from commit 985ba18)
This was referenced Aug 25, 2020
Merged
Merged
@jborean93
Copy link
Contributor Author

Backport PRs
stable-2.9 - #71433
stable-2.10 - #71434

@briantist
Copy link
Contributor

Very nice! I'm happy to see this as well.

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Aug 25, 2020
nitzmahone pushed a commit that referenced this pull request Aug 28, 2020
@jborean93
psrp - use native copy mechanism - 2.9 (#71433)
ed57b0c 
* psrp - use native copy mechanism (#71409)

* psrp - use native copy mechanism

* Fix sanity issues

* Split the bugfix and deprecation into separate changelog fragments

(cherry picked from commit 985ba18)

* Remove deprecations for backport
relrod pushed a commit that referenced this pull request Aug 28, 2020
@jborean93
psrp - use native copy mechanism - 2.10 (#71434)
5688fef 
* psrp - use native copy mechanism (#71409)

* psrp - use native copy mechanism

* Fix sanity issues

* Split the bugfix and deprecation into separate changelog fragments

(cherry picked from commit 985ba18)

* Removed deprecation warnings for backport
@ansible ansible locked and limited conversation to collaborators Sep 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

put_file method in psrp connection plugin breaks JEA
5 participants
@jborean93 @ansibot @egmar @briantist @mkrizek